Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected widget's outline should be visible when editor is in read-only. #6415

Closed
oleq opened this issue Mar 11, 2020 · 0 comments Β· Fixed by ckeditor/ckeditor5-theme-lark#272
Closed
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:widget type:bug This issue reports a buggy (incorrect) behavior.

Comments

@oleq
Copy link
Member

oleq commented Mar 11, 2020

πŸ“ Provide detailed reproduction steps (if any)

  1. Open an editor with a widget inside.
  2. editor.isReadOnly = true
  3. Select the widget using the handler

βœ”οΈ Expected result

image

❌ Actual result

What is the actual result of the above steps?
image

πŸ“ƒ Other details

In #1261 we got rid of it completely, which is wrong because you still can click the selection handler and copy the entire table. Users should be notified about this kind of widget selection just like they are notified about regular text selection in read-only mode.


If you'd like to see this fixed sooner, add a πŸ‘ reaction to this post.

@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. package:widget domain:ui/ux This issue reports a problem related to UI or UX. labels Mar 11, 2020
@oleq oleq added this to the iteration 31 milestone Mar 11, 2020
@Reinmar Reinmar modified the milestones: iteration 31, nice-to-have Mar 24, 2020
panr added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Mar 27, 2020
Fix: The selected widget's outline should be visible when the editor is read-only. Closes ckeditor/ckeditor5#6415.
@oleq oleq modified the milestones: nice-to-have, iteration 31 Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:widget type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
2 participants