Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder (with a watcher) crashes when a file is removed #62

Closed
Reinmar opened this issue Jan 13, 2016 · 1 comment
Closed

Builder (with a watcher) crashes when a file is removed #62

Reinmar opened this issue Jan 13, 2016 · 1 comment
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Jan 13, 2016

After #59 is finished this will happen:

[14:28:17] Processing '/www/ckeditor5/ckeditor5/tests/ckeditor5/path/getmodulepath.js'...
/www/ckeditor5/ckeditor5/dev/tasks/gulp/build/utils.js:149
            file.contents = new Buffer( file.contents.toString() + utils.benderLauncherCode );
                                                     ^

TypeError: Cannot read property 'toString' of null
    at DestroyableTransform._transform (/www/ckeditor5/ckeditor5/dev/tasks/gulp/build/utils.js:149:45)
    at DestroyableTransform.Transform._read (/www/ckeditor5/ckeditor5/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:172:10)
    at DestroyableTransform.Transform._write (/www/ckeditor5/ckeditor5/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:160:12)
    at doWrite (/www/ckeditor5/ckeditor5/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:335:12)

However, the issue is somewhere in the old code – I think that the watchers should be configured to care only about new files and changes in existing ones.

@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. module:builder labels Jan 13, 2016
@Reinmar
Copy link
Member Author

Reinmar commented Jan 13, 2016

If we have too much time we can also implement removing a proper file from the dist if the watcher is notified about removing one.

@Reinmar Reinmar modified the milestone: 0.1.0 Mar 4, 2016
mlewand pushed a commit that referenced this issue May 1, 2020
Internal: The FontSize plugin requires numerical values in the configuration (as options) if fontSize.supportAllValues was set on true. Closes #6550.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

1 participant