You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This happens only in Safari with links or mentions, and there are a few cases:
First example:
Open localhost:8125/ckeditor5-mention/tests/manual/mention-asynchronous.html
Select image caption text and type '@'
Select one of the mentions
Triple click on the mention
Try to type after the mention
✔️ Expected result
Whole mention should be selected with no crashes
❌ Actual result
App crashes
Errors:
[Error] CKEditorError: model-selection-setTo-not-selectable: Cannot set the selection to the given place. Read more: https://ckeditor.com/docs/ckeditor5/latest/framework/guides/support/error-codes.html#error-model-selection-setTo-not-selectable
fire (mention-asynchronous.js:117806)
domListener (mention-asynchronous.js:115536)
[Error] CKEditorError: model-nodelist-offset-out-of-bounds: Given offset cannot be found in the node list. Read more: https://ckeditor.com/docs/ckeditor5/latest/framework/guides/support/error-codes.html#error-model-nodelist-offset-out-of-bounds
{"offset":17,"nodeList":[{"attributes":{"mention":{"_uid":"e4ddfb9107d48ba6631360bb77c68b875","_text":"@angryrabbit821","id":"@angryrabbit821","username":"angryrabbit821","fullName":"Jackson Graves","thumbnail":"https://randomuser.me/api/portraits/thumb/men/61.jpg"}},"data":"@angryrabbit821"},{"data":" "}]}
fire (mention-asynchronous.js:117806)
domListener (mention-asynchronous.js:115536)
Second example:
Open ckeditor5 with table plugin
Create a table and create a link in some cell
Triple click on the link
✔️ Expected result
Link should be selected
❌ Actual result
App crashes
Error:
[Error] CKEditorError: model-selection-setTo-not-selectable: Cannot set the selection to the given place. Read more: https://ckeditor.com/docs/ckeditor5/latest/framework/guides/support/error-codes.html#error-model-selection-setTo-not-selectable
rethrowUnexpectedError (snippet.js:4:1482)
fire (snippet.js:4:22271)
n (snippet.js:4:120568)
📃 Other details
Browser: Safari
OS: macOS
CKEditor version: 5
Installed CKEditor plugins: Mention, Table
It also happens the other way round - when you triple click on link in a caption and a mention in a table.
I found some issues related to triple clicking in safari here: #1677
Fix (widget): Triple-clicking inside an image caption should not crash the editor in Firefox. Closes#7542.
Fix (widget): Triple-clicking a link inside an image caption should not crash the editor in Safari. Closes#6021.
📝 Provide detailed reproduction steps (if any)
This happens only in Safari with links or mentions, and there are a few cases:
First example:
✔️ Expected result
Whole mention should be selected with no crashes
❌ Actual result
App crashes
Errors:
Second example:
✔️ Expected result
Link should be selected
❌ Actual result
App crashes
Error:
📃 Other details
It also happens the other way round - when you triple click on link in a caption and a mention in a table.
I found some issues related to triple clicking in safari here:
#1677
and here:
#1463
but I guess this is a bit different behaviour.
If you'd like to see this fixed sooner, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: