Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restricted Editing Improvements #5992

Closed
panr opened this issue Dec 17, 2019 · 5 comments · Fixed by ckeditor/ckeditor5-theme-lark#262
Closed

Restricted Editing Improvements #5992

panr opened this issue Dec 17, 2019 · 5 comments · Fixed by ckeditor/ckeditor5-theme-lark#262
Assignees
@panr
Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:restricted-editing status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 29 (v17...

Comments

@panr
Copy link
Contributor

panr commented Dec 17, 2019 •
edited
Loading

In Restricted mode:

--
How to do this? Through CSS class? Any other ideas?
@panr panr added intro Good first ticket. module:ux package:restricted-editing status:discussion type:improvement This issue reports a possible enhancement of an existing feature. labels Dec 17, 2019
@jodator
Copy link
Contributor

jodator commented Dec 17, 2019 •
edited
Loading

  • cmd/ctrl + a inside current exception should select only text inside that exception (not all content inside editor)

Dup of: #5826.

@jodator
Copy link
Contributor

jodator commented Dec 17, 2019

  • root shouldn’t be editable (contenteditable = false), you don't want to see a caret in places that you can't edit.

That's one of the requirements - navigate through the docs using caret. So this might be either configurable or invalid. But I don't have a strong (any) opinion on that.

@panr
Copy link
Contributor Author

panr commented Dec 17, 2019

Dup of: #5826.

Cool 😎

@panr
Copy link
Contributor Author

panr commented Jan 13, 2020 •
edited
Loading

✅ cmd/ctrl + a inside current exception should select only text inside that exception (not all content inside editor) — ckeditor/ckeditor5-restricted-editing#16

@Reinmar Reinmar added domain:ui/ux This issue reports a problem related to UI or UX. and removed module:ux labels Jan 15, 2020
@panr panr mentioned this issue Jan 16, 2020
Merged
@panr
Copy link
Contributor Author

panr commented Jan 16, 2020

OK, I pushed the last PR related to the restricted editing improvements listed above.

@Reinmar Reinmar added this to the iteration 29 milestone Jan 21, 2020
Reinmar added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Jan 21, 2020
@Reinmar
Merge pull request #262 from ckeditor/i/5992
2602ab4 
Other: Set default cursor in restricted editing mode while restricted editing exceptions still have text cursor when you hover over them. Closes ckeditor/ckeditor5#5992.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@panr panr

Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:restricted-editing status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 29 (v17.0.0)
Development

Successfully merging a pull request may close this issue.

i/5992: Set default cursor in restricted editing mode ckeditor/ckeditor5-theme-lark
3 participants
@Reinmar @jodator @panr