Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The ck-restricted-editing-exception class should not contain the ck- prefix #5899

Closed
Reinmar opened this issue Dec 4, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-restricted-editing#6 or ckeditor/ckeditor5-theme-lark#258
Closed

The ck-restricted-editing-exception class should not contain the ck- prefix #5899

Reinmar opened this issue Dec 4, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-restricted-editing#6 or ckeditor/ckeditor5-theme-lark#258
Assignees
@panr
Labels
intro Good first ticket. package:restricted-editing type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 29 (v17...

Comments

@Reinmar
Copy link
Member

Reinmar commented Dec 4, 2019

It's part of the data so it should be logical in different, non-CKE related contexts.

cc @jodator
@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. package:restricted-editing status:confirmed labels Dec 4, 2019
@Reinmar Reinmar added this to the iteration 29 milestone Dec 4, 2019
@jodator jodator self-assigned this Dec 9, 2019
@mlewand mlewand added the intro Good first ticket. label Dec 9, 2019
@mlewand mlewand assigned panr and unassigned jodator Dec 9, 2019
This was referenced Dec 9, 2019
Merged
Merged
jodator added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Dec 9, 2019
@jodator
Merge pull request #258 from ckeditor/i/5899
599f16e 
Fix: Removed `ck-` prefix from CSS classes used in the editor content. Closes ckeditor/ckeditor5#5899.

BREAKING CHANGE: The restricted and standard mode editing now uses `ck-restricted-editing-exception` CSS class for spans used to mark editable content.
jodator added a commit to ckeditor/ckeditor5-restricted-editing that referenced this issue Dec 9, 2019
@jodator
Merge pull request #6 from ckeditor/i/5899
3ba00b0 
Other: Align CSS class names to the changes in the restricted editing feature. See ckeditor/ckeditor5#5899.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@panr panr

Labels
intro Good first ticket. package:restricted-editing type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 29 (v17.0.0)
4 participants
@Reinmar @jodator @panr @mlewand