Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special characters grid should render correctly in all browsers when there is a scrollbar #5831

Closed
oleq opened this issue Nov 26, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-special-characters#2
Closed

Special characters grid should render correctly in all browsers when there is a scrollbar #5831

oleq opened this issue Nov 26, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-special-characters#2
Assignees
@oleq
Labels
package:special-characters type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 29 (v17...

Comments

@oleq
Copy link
Member

oleq commented Nov 26, 2019 •
edited
Loading

✔️ Expected result

Nice padding around the grid (to the right, on the bottom, also when the scrollbar is displayed). Nothing hides behind the scrollbar.

❌ Actual result

Only in FF/Safari:
image

Also in Chrome:
image

Related to my SO question https://stackoverflow.com/questions/59055021/css-grid-renders-behind-parents-scroll-bar-in-firefox-and-safari.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed package:special-characters labels Nov 26, 2019
@oleq oleq changed the title Special characters grid should render correctly in all browsers Special characters grid should render correctly in all browsers when there is a scrollbar Nov 26, 2019
This was referenced Nov 29, 2019
Merged
Merged
@oleq oleq self-assigned this Nov 29, 2019
@mlewand mlewand added this to the iteration 29 milestone Dec 3, 2019
pomek added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Dec 9, 2019
@pomek
Merge pull request #257 from ckeditor/i/5831
7810a0f 
Internal: Improved special characters grid styles to prevent rendering issues (see ckeditor/ckeditor5#5831).
pomek added a commit to ckeditor/ckeditor5-special-characters that referenced this issue Dec 9, 2019
@pomek
Merge pull request #2 from ckeditor/i/5831
bf6c78f 
Fix: Special characters grid tile should render correctly when the scrollbar shows up in the panel (Safari, Firefox). Closes ckeditor/ckeditor5#5831.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:special-characters type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 29 (v17.0.0)
2 participants
@oleq @mlewand