Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow displaying keystroke info next to a button #5782

Closed
oleq opened this issue Nov 22, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-ui#531
Closed

Allow displaying keystroke info next to a button #5782

oleq opened this issue Nov 22, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-ui#531
Assignees
@oleq
Labels
package:theme-lark package:ui type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 28 (v16...

Comments

@oleq
Copy link
Member

oleq commented Nov 22, 2019

📝 Provide a description of the new feature

Just like so

image

Required by #5763.

If you'd like to see this feature implemented, add a 👍 reaction to this post.
@oleq oleq added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:theme-lark package:ui labels Nov 22, 2019
@oleq oleq added this to the iteration 28 milestone Nov 22, 2019
@oleq oleq self-assigned this Nov 22, 2019
This was referenced Nov 22, 2019
Merged
Merged
Reinmar added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Nov 25, 2019
@Reinmar
Merge pull request #252 from ckeditor/i/5782
8427306 
Feature: Implemented styles for `.ck-button` with a keystroke preview (see ckeditor/ckeditor5#5782).
Reinmar added a commit to ckeditor/ckeditor5-ui that referenced this issue Nov 25, 2019
@Reinmar
Merge pull request #531 from ckeditor/i/5782
dac8ce0 
Feature: Enabled keystroke preview in `ButtonView`. Implemented the `ButtonView#withKeystroke` property. Closes ckeditor/ckeditor5#5782.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:theme-lark package:ui type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 28 (v16.0.0)
Development

Successfully merging a pull request may close this issue.

i/5782: Enabled keystroke preview in ButtonView ckeditor/ckeditor5-ui
1 participant
@oleq