Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code block feature guide should come with GIFs showcasing editing features #5747

Closed
oleq opened this issue Nov 18, 2019 · 0 comments
Closed
Assignees
Labels
package:code-block type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@oleq
Copy link
Member

oleq commented Nov 18, 2019

A follow-up of #5668.

GIF scenarios

Editing text around code blocks

Before

  1. Use 1LOC code snippet.
    console.log( 'Hello World' );
  2. Follow the scenario in the guide.

After

  1. Use 1LOC code snippet.
    console.log( 'Hello World' );
  2. Follow the scenario in the guide.

Changing line indentation

  1. Use the following code snippet:

    	function log( message ) {
    	console.log( message );
    	}
  2. Select the entire snippet.

  3. Outdent.

  4. Move the caret before the second line and indent it.

Preserving line indentation

  1. Use the following code snippet:

    function log( message ) {
    	message = message.toLowerCase();
    }
  2. Put the selection after message = message.toLowerCase();

  3. Enter (new line created, preserved indent).

  4. Type console.log( message ).

@oleq oleq added type:task This issue reports a chore (non-production change) and other types of "todos". package:code-block labels Nov 18, 2019
@Reinmar Reinmar added this to the iteration 28 milestone Dec 2, 2019
@Reinmar Reinmar modified the milestones: iteration 28, iteration 29 Dec 5, 2019
Reinmar added a commit to ckeditor/ckeditor5-code-block that referenced this issue Dec 16, 2019
Docs: Added gifs showcasing tips & tricks. Closes ckeditor/ckeditor5#5747.
@Reinmar Reinmar closed this as completed Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:code-block type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

3 participants