Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rel='noopener noreferrer' to the link preview (in the balloon) #5746

Closed
Reinmar opened this issue Nov 18, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-link#251
Closed

Add rel='noopener noreferrer' to the link preview (in the balloon) #5746

Reinmar opened this issue Nov 18, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-link#251
Assignees
@oleq
Labels
intro Good first ticket. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 28 (v16...

Comments

@Reinmar
Copy link
Member

Reinmar commented Nov 18, 2019

I think it's quite self-explanatory. We use target=_blank, but we don't use the rel attribute to further secure the app.
@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. intro Good first ticket. labels Nov 18, 2019
@Reinmar Reinmar added this to the iteration 28 milestone Nov 18, 2019
@oleq oleq mentioned this issue Nov 18, 2019
Merged
jodator added a commit to ckeditor/ckeditor5-link that referenced this issue Nov 18, 2019
@jodator
Merge pull request #251 from ckeditor/i/5746
5b921b4 
Fix: Link preview in the balloon should have `rel="noopener noreferrer"` set for security reasons. Closes ckeditor/ckeditor5#5746.
@arkflpc arkflpc mentioned this issue Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
intro Good first ticket. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 28 (v16.0.0)
Development

Successfully merging a pull request may close this issue.

i/5746: Link preview in the balloon should have rel="noopener noreferrer" ckeditor/ckeditor5-link
2 participants
@Reinmar @oleq