Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to move the selection under the code block when it is the last element in the document #5666

Closed
oskarwrobel opened this issue Oct 25, 2019 · 2 comments · Fixed by ckeditor/ckeditor5-code-block#1
Closed

How to move the selection under the code block when it is the last element in the document #5666

oskarwrobel opened this issue Oct 25, 2019 · 2 comments · Fixed by ckeditor/ckeditor5-code-block#1
Assignees
@oleq
Labels
package:code-block type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 28 (v16...

Comments

@oskarwrobel
Copy link
Contributor

Follow-up: #436.

AFAIR It's a known problem of widgets.

Oct-25-2019 17-20-29
@oskarwrobel oskarwrobel added the type:task This issue reports a chore (non-production change) and other types of "todos". label Oct 25, 2019
@oskarwrobel oskarwrobel mentioned this issue Oct 25, 2019
Merged
5 tasks
@pjasiun
Copy link

pjasiun commented Oct 28, 2019

Yea, that's tricky. First I wanted to write that it should be done the same way it is done in the blockquote, so double enter should leave the block, but then I realized that it would be very annoying whenever you want to create an empty line in your code.

@oskarwrobel
Copy link
Contributor Author

First I wanted to write that it should be done the same way it is done in the blockquote, so double enter should leave the block, but then I realized that it would be very annoying whenever you want to create an empty line in your code.

I had the same thoughts.

@Mgsy Mgsy added this to the backlog milestone Oct 29, 2019
@oleq oleq self-assigned this Nov 15, 2019
@oleq oleq modified the milestones: backlog, iteration 28 Nov 15, 2019
jodator added a commit to ckeditor/ckeditor5-code-block that referenced this issue Nov 20, 2019
@jodator
Merge pull request #1 from ckeditor/t/ckeditor5/436
eb9ef5e 
Feature: Initial implementation of the code block feature. Closes ckeditor/ckeditor5#436. Closes ckeditor/ckeditor5#5664. Closes ckeditor/ckeditor5#5666.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:code-block type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 28 (v16.0.0)
Development

Successfully merging a pull request may close this issue.

Initial implementation of the code block feature ckeditor/ckeditor5-code-block
4 participants
@oskarwrobel @oleq @pjasiun @Mgsy