Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MathType plugin doesn't work #5613

Closed
Mgsy opened this issue Oct 17, 2019 · 6 comments · Fixed by #5646
Closed

MathType plugin doesn't work #5613

Mgsy opened this issue Oct 17, 2019 · 6 comments · Fixed by #5646
Assignees
Labels
package:mathtype type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Mgsy
Copy link
Member

Mgsy commented Oct 17, 2019

📝 Provide a description of requested docs changes

MathType demo doesn't work in the latest docs. The editor loads without a formula and it's not possible to insert new formulas.

@Mgsy Mgsy added type:bug This issue reports a buggy (incorrect) behavior. type:docs This issue reports a task related to documentation (e.g. an idea for a guide). labels Oct 17, 2019
@Mgsy Mgsy added this to the iteration 27 milestone Oct 17, 2019
@oleq
Copy link
Member

oleq commented Oct 17, 2019

Things land in the model/view but they don't render

image

image

@jodator
Copy link
Contributor

jodator commented Oct 17, 2019

Same on Android - something is in the editing area but I don't see anything.

@Reinmar
Copy link
Member

Reinmar commented Oct 18, 2019

It works fine on https://ckeditor.com/docs/ckeditor5/latest/features/mathtype.html so this may be something on our side. Could you bisect when it stopped working? It's perhaps worth to build the docs from stable and see if it works there too.

@Reinmar
Copy link
Member

Reinmar commented Oct 18, 2019

OK, got it. It's due to the xmlns attribute used on <img>. MathType should not add it there because it's completely invalid in this context.

@mlewand mlewand changed the title [Docs] MathType demo doesn't work MathType plugin doesn't work Oct 21, 2019
@mlewand mlewand added status:confirmed package:mathtype and removed type:docs This issue reports a task related to documentation (e.g. an idea for a guide). labels Oct 21, 2019
@mlewand
Copy link
Contributor

mlewand commented Oct 22, 2019

The issue has been fixed by MathType team in their upcoming release. We checked https://github.com/wiris/mathtype-ckeditor5/tree/4594e7fae89a1b0c0a15cf756774feadbdbb81fa and it indeed no longer have this issue.

We got information that the release will be published today. So we should update the version in deps as soon as it's published and we're good to go.

@mlewand mlewand self-assigned this Oct 22, 2019
@mlewand
Copy link
Contributor

mlewand commented Oct 22, 2019

Version 7.17.1 has been released a moment ago.

On a side note, I don't know how is that possible that we already had a dependency on non-existent (back then) 7.17.1 version already 😂

Anyway this means that it should work out of the box as long as yarn.lock will get updated too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:mathtype type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants