Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Enter image caption" placeholder shows up when clicking the caption–less image in read–only mode #5168

Closed
oleq opened this issue Nov 6, 2018 · 1 comment · Fixed by #8727
Closed

"Enter image caption" placeholder shows up when clicking the caption–less image in read–only mode #5168

oleq opened this issue Nov 6, 2018 · 1 comment · Fixed by #8727
Assignees
@magda-chrzescian
Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:image squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 39 (v25...

Comments

@oleq
Copy link
Member

oleq commented Nov 6, 2018

  1. Go to http://localhost:8125/ckeditor5-image/tests/manual/caption.html
  2. editor.isReadOnly = true
  3. Click an image without a caption.

Expected: Nothing happens

Actual: The placeholder shows up and you can't use it.

image
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the backlog milestone Oct 9, 2019
@mlewand mlewand added domain:ui/ux This issue reports a problem related to UI or UX. module:ux type:bug This issue reports a buggy (incorrect) behavior. package:image labels Oct 9, 2019
@Reinmar Reinmar removed the module:ux label Jan 15, 2020
@anuradhawick
Copy link

What is the current status of this bug? I am having the same problem and it looks a bit confusing on the read-only plane.

@oleq oleq added the intro Good first ticket. label Jul 6, 2020
@Reinmar Reinmar added squad:core Issue to be handled by the Core team. and removed squad:red labels Jul 28, 2020
@oleq oleq modified the milestones: backlog, iteration 39 Dec 21, 2020
@magda-chrzescian magda-chrzescian mentioned this issue Dec 29, 2020
Merged
niegowski added a commit that referenced this issue Dec 30, 2020
@niegowski
Merge pull request #8727 from ckeditor/i/5168-captions-in-readonly
cab4065 
Fix (image): An empty image caption should be hidden if an editor is in the read-only mode. Closes #5168.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magda-chrzescian magda-chrzescian

Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:image squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 39 (v25.0.0)
Development

Successfully merging a pull request may close this issue.

Not showing empty image caption if editor is in readOnly mode. ckeditor/ckeditor5
5 participants
@Reinmar @oleq @mlewand @anuradhawick @magda-chrzescian