Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement autolinking feature #4715

Closed
oskarwrobel opened this issue Aug 22, 2016 · 5 comments · Fixed by #7478
Closed

Implement autolinking feature #4715

oskarwrobel opened this issue Aug 22, 2016 · 5 comments · Fixed by #7478
Assignees
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@oskarwrobel
Copy link
Contributor

oskarwrobel commented Aug 22, 2016

Create autolinking mechanism as separate feature. After new content is inserted to the editor, editor should detect matched URL and automatically transforms it to link.

In addition to URLs it might also support email addresses.

@oleq
Copy link
Member

oleq commented Aug 24, 2016

@oskarwrobel I created an issue, which partially concerns the UX approach to auto linking in https://github.com/ckeditor/ckeditor5-link/issues/14.

@faran52000
Copy link

I've tried an implementation of autolink in ckeditor 5 here you can check it out
https://github.com/faran52000/ckeditor-custom/tree/master/src/plugins/autolink

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the backlog milestone Oct 9, 2019
@mlewand mlewand added module:ux type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:link labels Oct 9, 2019
@robclancy
Copy link

robclancy commented Dec 12, 2019

This is incredible. How is this not a thing? We have auto embed links, which can be super intrusive and if you want to disable it you need a custom build, but links don't link?

When you use the medit provider

{
    name: 'allow-all',
    url: /^.+/
}

Then you actually get all links converted to media, which with auto embed ruins things now. But the point is that the functionality is right there.

This is so surprising. This is something I would want to PR right away, basically copying the functionality from auto embed. But there is no indication on if a PR will even be accepted on here anymore.

@lslowikowska lslowikowska added the support:2 An issue reported by a commercially licensed client. label Dec 31, 2019
@Reinmar Reinmar added domain:ui/ux This issue reports a problem related to UI or UX. and removed module:ux labels Jan 15, 2020
@qisaw
Copy link

qisaw commented Jan 20, 2020

Seems like this has been an issue for a few years without any progress. Is this something the CKEditor team still want to address?

@jodator jodator modified the milestones: backlog, iteration 33 Jun 16, 2020
@jodator jodator self-assigned this Jun 16, 2020
@jodator
Copy link
Contributor

jodator commented Jun 16, 2020

After some fiddling with it - I'm not sure if the paste scenario is OK - or should be the only one.

Behavior

I've checked GDocs & Word online and both works the same - the link is pasted as plain text. The autolinking happens on space & (shift-) enter. So it might be that this is what user would expect from this.

It should undo link on ctrl+z.

Enabling

I guess the AutoLink plugin would be enough to have this as opt-in (opt-out) - similarly to AutoMediaEmbed. At this point I don't see a need for configuration (to not bloat our config). I'd start with autolinking links & emails.


The other thing is to implement the CTRL+K handling when selection (collapsed?) is inside link - but that's different story (#4722).

@Reinmar Reinmar modified the milestones: iteration 33, iteration 34 Jun 22, 2020
pomek added a commit that referenced this issue Jun 24, 2020
Feature (link): Added the `AutoLink` feature which replaces a plain text with a link if typed or pasted content is the link. Closes #4715.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants