-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite widget resizer unit tests #4614
Rewrite widget resizer unit tests #4614
Comments
@Reinmar Just one thing needs to be clarified before we go further:
|
Mock mouse movements in a safe and stable way. The rest can come from the browser. The problem with the current tests is that to workaround the hidpi/lowdpi issue you created tests which sometimes give X, sometimes X+1 results which made them far more complex than what they need to be. Currently, every time when you could've used a simple The goal is to make tests simple. Abusing mocks don't make them simple and/or realistic. Agreeing to browser's inconsistencies or the effect of the environment also makes things complex. The choice needs to be pragmatic and based on what can simplify tests as simple and as realistic as they can be. |
Tests: Extracted relevant parts of widget resize plugin from the image back to widget plugin. Closes ckeditor/ckeditor5#4614.
Tests: Extracted relevant parts of widget resize plugin from the image back to widget plugin. Closes ckeditor/ckeditor5#4614.
Is this a bug report or feature request?
Task
📋 Steps to reproduce
Currently widget resizer is tested solely by image resizer integration tests.
There are couple of issues with that:
The text was updated successfully, but these errors were encountered: