Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change deleteContent() default behaviour to "merge" #4090

Closed
Reinmar opened this issue Jun 26, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-engine#983
Closed

Change deleteContent() default behaviour to "merge" #4090

Reinmar opened this issue Jun 26, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-engine#983
Assignees
@Reinmar
Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 11

Comments

@Reinmar
Copy link
Member

Reinmar commented Jun 26, 2017

As noticed in https://github.com/ckeditor/ckeditor5-typing/issues/97 – all algorithms except the enter command do merge the blocks by default so it's more reasonable that this is the default behaviour.

I'm going to change the merge option to doNotMerge, so the default value can be false.
@Reinmar Reinmar self-assigned this Jun 26, 2017
@Reinmar
Copy link
Member Author

Reinmar commented Jun 26, 2017

What do you think about leaveUnmerged? Will it be easier to read (with less visible double negation).

szymonkups referenced this issue in ckeditor/ckeditor5-engine Jun 28, 2017
@szymonkups
Merge pull request #983 from ckeditor/t/982
56347d1 
Other: Changed the `merge` option of `DataController.deleteContent()` to `leaveUnmerged`. The default value stayed `false`, so the default behavior of the function was changed to merge blocks. Closes #982.

BREAKING CHANGE: The `DataController.deleteContent()` option was renamed from `merge` to `leaveUnmerged` and the default behavior of the function was changed to merge blocks.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Oct 9, 2019
@Reinmar Reinmar mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Reinmar Reinmar

Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

t/982: Changed merge option to leaveUnmerged ckeditor/ckeditor5-engine
2 participants
@Reinmar @mlewand