Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On typing, existing content should be deleted with merge:true #3089

Closed
Reinmar opened this issue Apr 6, 2017 · 2 comments
Closed

On typing, existing content should be deleted with merge:true #3089

Reinmar opened this issue Apr 6, 2017 · 2 comments
Assignees
Labels
package:typing type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Apr 6, 2017

The bug is described here: https://github.com/ckeditor/ckeditor5-engine/issues/670.

It's even better visible in http://localhost:8125/ckeditor5-presets/tests/manual/article.html where the content ends with a block quote. In this case, the block quote remains.

This happens because deleteContent() is called without merge: true:

https://github.com/ckeditor/ckeditor5-typing/blob/f26c3ba5a060e4644947b7f3a4097c0b3b06e0e2/src/input.js#L79

@Reinmar Reinmar self-assigned this Jun 26, 2017
@Reinmar
Copy link
Member Author

Reinmar commented Jun 26, 2017

I can see that merge:true is passed in all cases but this... where it's a bug ;D

So, I'm going to change the merge option to doNotMerge so by default it will merge (https://github.com/ckeditor/ckeditor5-engine/issues/982).

@Reinmar
Copy link
Member Author

Reinmar commented Jun 26, 2017

All changes, including a test for this issue landed in ckeditor/ckeditor5-engine#983.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-typing Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:typing labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:typing type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

2 participants