Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pasting page breaks #2508

Closed
mlewand opened this issue Sep 25, 2019 · 0 comments · Fixed by #7629
Closed

Support pasting page breaks #2508

mlewand opened this issue Sep 25, 2019 · 0 comments · Fixed by #7629
Assignees
@niegowski
Labels
package:paste-from-office support:3 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 34 (v21...

Comments

@mlewand
Copy link
Contributor

mlewand commented Sep 25, 2019

Is this a bug report or feature request?

🆕 Feature request

💻 Version of CKEditor

CKEditor v5 @ 12.4.0

📋 Steps to reproduce

Once #1194 is done we should add a converter for page breaks coming from MS Office.

To save you the trouble I'll paste here an example markup that is placed in Chrome from Word 2013 (note it would be nice to verify with the latest release, didn't had one at hand now):

<p class=MsoNormal>First line, followed by break line:<o:p></o:p>
</p>

<span style='font-size:11.0pt;line-height:107%;font-family:"Calibri",sans-serif;
mso-ascii-theme-font:minor-latin;mso-fareast-font-family:"MS Mincho";
mso-fareast-theme-font:minor-fareast;mso-hansi-theme-font:minor-latin;
mso-bidi-font-family:"Times New Roman";mso-bidi-theme-font:minor-bidi;
mso-ansi-language:EN-US;mso-fareast-language:JA;mso-bidi-language:AR-SA'><br clear=all
		style='mso-special-character:line-break;page-break-before:always'>
</span>

<p class=MsoNormal>
	<o:p>&nbsp;</o:p>
</p>

So it boils down to recognizing <br clear=all style='mso-special-character:line-break;page-break-before:always'>.

If you'd like to see this feature implemented, add 👍 to this post.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-paste-from-office Oct 9, 2019
@mlewand mlewand added this to the nice-to-have milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:paste-from-office labels Oct 9, 2019
@Reinmar Reinmar added squad:red support:1 An issue reported by a commercially licensed client. labels Jun 16, 2020
@niegowski niegowski modified the milestones: nice-to-have, iteration 34 Jul 14, 2020
@niegowski niegowski self-assigned this Jul 15, 2020
@niegowski niegowski mentioned this issue Jul 15, 2020
Merged
pomek added a commit that referenced this issue Jul 16, 2020
@pomek
Merge pull request #7629 from ckeditor/i/2508
d921aab 
Feature (page-break): Added support for pasting page breaks from MS Word. Closes #2508.

Tests (paste-from-office): Added test for pasting page breaks from MS Word.
@lslowikowska lslowikowska added support:3 An issue reported by a commercially licensed client. and removed support:1 An issue reported by a commercially licensed client. labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
package:paste-from-office support:3 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 34 (v21.0.0)
Development

Successfully merging a pull request may close this issue.

#2508: Support for pasting page breaks ckeditor/ckeditor5
4 participants
@Reinmar @niegowski @mlewand @lslowikowska