Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't add an image to a table #1985

Closed
elszczepano opened this issue Aug 21, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-image#316
Closed

Can't add an image to a table #1985

elszczepano opened this issue Aug 21, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-image#316
Assignees
@jodator
Labels
package:image package:table package:ui type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 26

Comments

@elszczepano
Copy link
Member

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

Latest

📋 Steps to reproduce

Try to add an image to an existing table. The image isn't displayed and only image caption appears.

✅ Expected result

Image added to the table

❎ Actual result

The image is not added to the table. Various errors in the console.

📃 Other details that might be useful

Console shows errors like:

TypeError: undefined is not an object (evaluating 'entry[ 0 ]')

TypeError: this._visibleStack is undefined
TypeError: entry is undefined

Screenshot 2019-08-21 at 11 25 42
@elszczepano elszczepano added type:bug This issue reports a buggy (incorrect) behavior. and removed type:bug This issue reports a buggy (incorrect) behavior. labels Aug 21, 2019
@jodator jodator self-assigned this Aug 21, 2019
@jodator jodator added package:image package:table package:ui type:bug This issue reports a buggy (incorrect) behavior. labels Aug 21, 2019
@jodator jodator mentioned this issue Aug 21, 2019
Merged
@Mgsy Mgsy added this to the iteration 26 milestone Aug 21, 2019
@mlewand mlewand mentioned this issue Aug 22, 2019
Closed
35 tasks
jodator added a commit to ckeditor/ckeditor5-image that referenced this issue Aug 23, 2019
@jodator
Merge pull request #316 from ckeditor/t/ckeditor5/1985
5a729d3 
Fix: Image upload should handle images that are deeply nested in other blocks. Closes ckeditor/ckeditor5#1985.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:image package:table package:ui type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 26
Development

Successfully merging a pull request may close this issue.

T/ckeditor5/1985: Change how the temporary upload image is handled. ckeditor/ckeditor5-image
4 participants
@jodator @mlewand @Mgsy @elszczepano