Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS variable "--ck-image-upload-progress-line-width" is duplicated #1915

Closed
pomek opened this issue Jul 26, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-theme-lark#240
Closed

CSS variable "--ck-image-upload-progress-line-width" is duplicated #1915

pomek opened this issue Jul 26, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-theme-lark#240
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 26

Comments

@pomek
Copy link
Member

pomek commented Jul 26, 2019

Is this a bug report or feature request? (choose one)

🐞 Bug report

📃 Other details that might be useful

While I was fixing #1805, I found duplicated definition of the --ck-image-upload-progress-line-width variable.
@pomek pomek added the type:bug This issue reports a buggy (incorrect) behavior. label Jul 26, 2019
@Mgsy
Copy link
Member

Mgsy commented Jul 30, 2019

cc @dkonopka

@Mgsy Mgsy added this to the iteration 26 milestone Jul 30, 2019
@dkonopka dkonopka mentioned this issue Jul 31, 2019
Merged
oleq added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Jul 31, 2019
@oleq
Merge pull request #240 from ckeditor/t/ckeditor5-theme-lark/239
cb92793 
Other: The `.ck-progress-bar` styles should not be under with `.ck-content`. Additionaly removed two unused custom properties: `--ck-color-upload-infinite-background` and `--ck-image-upload-progress-line-width`. Closes https://github.com/ckeditor/ckeditor5-theme-lark/issues/239. Closes ckeditor/ckeditor5#1915.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 26
2 participants
@pomek @Mgsy