Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV] releaseTools.getNextPreRelease() returns invalid numbers after .10 #16576

Closed
pomek opened this issue Jun 17, 2024 · 0 comments · Fixed by ckeditor/ckeditor5-dev#960
Closed
Assignees
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@pomek
Copy link
Member

pomek commented Jun 17, 2024

📝 Provide detailed reproduction steps (if any)

Nightly alpha releases from the #release branch stopped working during the last weekend.

CI logs presets as follows:

Version 42.0.0-alpha.10
[STARTED] Verify the repository.
[SKIPPED] Verify the repository.
[STARTED] Preparation phase.
[STARTED] Updating "version" value.
[FAILED] The "@ckeditor/ckeditor5-editor-inline@******-alpha.10" already exists in the npm registry.
[FAILED] The "@ckeditor/ckeditor5-editor-inline@******-alpha.10" already exists in the npm registry.

It tried several times to push the already published version:

image

✔️ Expected result

  • There are no errors, and the release process goes fine.
  • The next proposed @alpha version should be incremented precisely.

❌ Actual result

As mentioned in the issue description.

❓ Possible solution

A quick debug session led me to https://github.com/ckeditor/ckeditor5-dev/blob/f0e2026c0d9889eedfb99bfeacaf8dd13b01b9e4/packages/ckeditor5-dev-release-tools/lib/utils/versions.js#L45-L48

It returns:

[
  '42.0.0-alpha.0',
  '42.0.0-alpha.1',
  '42.0.0-alpha.10',
  '42.0.0-alpha.2',
  '42.0.0-alpha.3',
  '42.0.0-alpha.4',
  '42.0.0-alpha.5',
  '42.0.0-alpha.6',
  '42.0.0-alpha.7',
  '42.0.0-alpha.8',
  '42.0.0-alpha.9'
]

while it should be

[
  '42.0.0-alpha.0',
  '42.0.0-alpha.1',
  '42.0.0-alpha.2',
  '42.0.0-alpha.3',
  '42.0.0-alpha.4',
  '42.0.0-alpha.5',
  '42.0.0-alpha.6',
  '42.0.0-alpha.7',
  '42.0.0-alpha.8',
  '42.0.0-alpha.9',
  '42.0.0-alpha.10'
]
@pomek pomek added type:bug This issue reports a buggy (incorrect) behavior. squad:platform Issue to be handled by the Platform team. package:dev labels Jun 17, 2024
@psmyrek psmyrek self-assigned this Jun 17, 2024
@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Jun 17, 2024
pomek added a commit to ckeditor/ckeditor5-dev that referenced this issue Jun 17, 2024
Fix (release-tools): Fixed the `getLastPreRelease()` function to handle pre-release versions with a multi-digit sequence number correctly. Closes ckeditor/ckeditor5#16576.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jun 17, 2024
@CKEditorBot CKEditorBot added this to the iteration 76 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
3 participants