Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align the bump year script to changes in licenses #15286

Closed
pomek opened this issue Oct 31, 2023 · 0 comments · Fixed by ckeditor/ckeditor5-dev#929
Closed

Align the bump year script to changes in licenses #15286

pomek opened this issue Oct 31, 2023 · 0 comments · Fixed by ckeditor/ckeditor5-dev#929
Assignees
@przemyslaw-zan
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 68 (v40...

Comments

@pomek
Copy link
Member

pomek commented Oct 31, 2023

Provide a description of the task

In #15279, we will use en dash (–) as a separator between years.

To avoid overriding changes from the PR, the bump year script should support both values.

https://github.com/ckeditor/ckeditor5-dev/blob/373d92aeeea59fc2fe68de619e97364ec8cbcd2f/packages/ckeditor5-dev-bump-year/lib/bumpyear.js#L58
@pomek pomek added type:task This issue reports a chore (non-production change) and other types of "todos". squad:platform Issue to be handled by the Platform team. package:dev labels Oct 31, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Nov 6, 2023
@przemyslaw-zan przemyslaw-zan self-assigned this Nov 7, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Nov 7, 2023
@przemyslaw-zan przemyslaw-zan mentioned this issue Nov 7, 2023
Merged
pomek added a commit to ckeditor/ckeditor5-dev that referenced this issue Nov 8, 2023
@pomek
Merge pull request #929 from ckeditor/ck/15286
255c1e8 
Other (bump-year): The bump year script supports both _hyphen_ and _en dash_ symbols in the year range. Closes ckeditor/ckeditor5#15286.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Nov 8, 2023
@CKEditorBot CKEditorBot added this to the iteration 68 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@przemyslaw-zan przemyslaw-zan

Labels
package:dev squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 68 (v40.1.0)
Development

Successfully merging a pull request may close this issue.

Allowed different dash type in bump year script ckeditor/ckeditor5-dev
3 participants
@pomek @CKEditorBot @przemyslaw-zan