Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caption field is not displayed inside an image when in a table #1524

Closed
Reinmar opened this issue Feb 12, 2019 · 1 comment
Closed

Caption field is not displayed inside an image when in a table #1524

Reinmar opened this issue Feb 12, 2019 · 1 comment
Assignees
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Feb 12, 2019

There should be a caption field visible:

image

Most likely related to #1523 and issues with fake selection.

@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed labels Feb 12, 2019
@Reinmar Reinmar added this to the iteration 22 milestone Feb 12, 2019
@jodator jodator self-assigned this Feb 15, 2019
@jodator
Copy link
Contributor

jodator commented Feb 15, 2019

So the problem is with the image caption postfixer has limited information about inserted nodes from the differ. Differ returns change for whole tree, ie type="insert" name="table" so image caption feature must look not only for inserted nodes but also check if some of the children aren't images.

The same thing happens with <blockquote><image /></blockqoute> when parsing or pasting content.

scofalik added a commit to ckeditor/ckeditor5-image that referenced this issue Feb 18, 2019
Fix: Insert missing caption for images that are nested in other elements. Closes ckeditor/ckeditor5#1524.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

2 participants