Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing name global when scrolling ckeditor - header does not stick #14801

Closed
FreexD opened this issue Aug 16, 2023 · 5 comments · Fixed by #14808
Closed

Missing name global when scrolling ckeditor - header does not stick #14801

FreexD opened this issue Aug 16, 2023 · 5 comments · Fixed by #14808
Assignees
@filipsobol
Labels
pending:feedback This issue is blocked by necessary feedback. squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Milestone
iteration 66 (v39...

Comments

@FreexD
Copy link

FreexD commented Aug 16, 2023

📝 Provide detailed reproduction steps (if any)

  1. Trrying to scroll ckedtor-5 on version 39.0.1.

✔️ Expected result

The header sticks properly and no error is in the console.

❌ Actual result

The header does not stick and it errors in the console - missing name global.

❓ Possible solution

Missin global import import global from './global'; in https://github.com/ckeditor/ckeditor5/blob/master/packages/ckeditor5-utils/src/dom/getelementsintersectionrect.ts .

📃 Other details

  • Browser: Chrome
  • OS: MacOS
  • First affected CKEditor version: 39.0.1

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@FreexD FreexD added the type:bug This issue reports a buggy (incorrect) behavior. label Aug 16, 2023
@FreexD FreexD changed the title Missing name global when new ckeditor. Missing name global when scrolling ckeditor - header does not stick Aug 16, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Aug 17, 2023
@Witoso
Copy link
Member

Witoso commented Aug 17, 2023

Thanks for reporting! cc @filipsobol

@Witoso
Copy link
Member

Witoso commented Aug 17, 2023

We noticed it doesn't work in the Vite setup (ckeditor/vite-plugin-ckeditor5#17). @FreexD could you share the details about your setup?

@Witoso Witoso added pending:feedback This issue is blocked by necessary feedback. type:regression This issue reports a bug that was not present in the previous releases. labels Aug 17, 2023
@FreexD
Copy link
Author

FreexD commented Aug 17, 2023

@Witoso I was testing on a Vite setup as well.

@Witoso Witoso added the squad:core Issue to be handled by the Core team. label Aug 17, 2023
@filipsobol
Copy link
Member

This issue will be fixed by PR #14808.

@filipsobol filipsobol self-assigned this Aug 17, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Aug 17, 2023
This was referenced Aug 21, 2023
Closed
Closed
@filipsobol filipsobol mentioned this issue Aug 25, 2023
Merged
@filipsobol filipsobol linked a pull request Aug 25, 2023 that will close this issue
fix: load only specified typings for TypeScript #14808
Merged
filipsobol added a commit that referenced this issue Aug 25, 2023
@filipsobol
fix: load only specified typings for TypeScript (#14808)
b7a984b 
Fix: Don't rely on `global` object available only in Node. Fixes ckeditor/vite-plugin-ckeditor5#17 and #14801.

Internal: Load only specified typings for TypeScript. Closes #14173.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Aug 25, 2023
@CKEditorBot CKEditorBot added this to the iteration 66 milestone Aug 25, 2023
@CKEditorBot CKEditorBot mentioned this issue Aug 25, 2023
Open
@filipsobol
Copy link
Member

The fix for this issue has been merged (PR #14808) and will be available in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filipsobol filipsobol

Labels
pending:feedback This issue is blocked by necessary feedback. squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
Milestone
iteration 66 (v39.0.2)
Development

Successfully merging a pull request may close this issue.

fix: load only specified typings for TypeScript ckeditor/ckeditor5
4 participants
@filipsobol @FreexD @Witoso @CKEditorBot