-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't add youtube with bootstrap #1373
Comments
Hi! Could you create a sample on e.g. JSFiddle on which we could reproduce this issue? |
I am having this problem too. Confirmed not working with bootstrap 4.1.3 Looks like both ckeditor and bootstrap4 use the class .media. Bootstrap sets it to display:flex. Overriting it with display:block fixes the problem (maybe) |
See #1391 (comment). Apparently Bootstrap sets some styles for cc @oleq |
@Reinmar display:block works too. |
Yes, it's true bootstrap 4 overwrites https://github.com/twbs/bootstrap/blob/v4-dev/scss/_media.scss#L1-L4 ATM it's easy to fix it with with stronger CSS Specificity: .ck-content .media {
display: block;
} Anyways we could introduce this fix by default in our ckeditor5-media-embed CSS. |
Thank you! |
Fix: Media embed figures should have `display: block` in the content styles to prevent Bootstrap from changing their appearance. Closes ckeditor/ckeditor5#1373.
In my webpage doesn't work...
we can't see the movie. (by this tag) |
Is this a bug report or feature request? (choose one)
🐞 Bug report
💻 Version of CKEditor
https://cdn.ckeditor.com/ckeditor5/11.1.1/classic/ckeditor.js
📋 Steps to reproduce
I can't add any youtube videos on CKEditor5 editor.
✅ Expected result
youtube video
❎ Actual result
no video
📃 Other details that might be useful
The text was updated successfully, but these errors were encountered: