Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard navigation in grid dropdowns should not be reversed in RTL editor #12871

Closed
Dumluregn opened this issue Nov 17, 2022 · 0 comments · Fixed by #12899
Closed

Keyboard navigation in grid dropdowns should not be reversed in RTL editor #12871

Dumluregn opened this issue Nov 17, 2022 · 0 comments · Fixed by #12899
Assignees
@illia-stv
Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 59 (v35...

Comments

@Dumluregn
Copy link
Contributor

Dumluregn commented Nov 17, 2022 •
edited
Loading

📝 Provide detailed reproduction steps (if any)

  1. Open demo with RTL editor.
  2. Open the insert table dropdown.
  3. Press arrow left.

✔️ Expected result

❌ Actual result

❓ Possible solution

The right/left arrow navigation is reversed. It should work naturally instead.

The same thing happens for all grids in the editor UI:

  • color picker
  • styles
  • special characters
  • list styles

📃 Other details

  • Browser: …
  • OS: …
  • First affected CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@Dumluregn Dumluregn added type:bug This issue reports a buggy (incorrect) behavior. package:table squad:features Issue to be handled by the Features team. labels Nov 17, 2022
@mlewand mlewand added intro Good first ticket. domain:ui/ux This issue reports a problem related to UI or UX. labels Nov 18, 2022
@illia-stv illia-stv mentioned this issue Nov 21, 2022
Closed
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Nov 21, 2022
@illia-stv illia-stv mentioned this issue Nov 21, 2022
Merged
@illia-stv illia-stv self-assigned this Nov 21, 2022
@Dumluregn Dumluregn changed the title Keyboard navigation in "Insert table" dropdown should not be reversed in RTL editor Keyboard navigation in grid dropdowns should not be reversed in RTL editor Nov 21, 2022
Dumluregn added a commit that referenced this issue Nov 29, 2022
@Dumluregn
Merge pull request #12899 from ckeditor/ck/12871-keyboard-navigation-…
d5c8363 
…reverse

Fix (ui): Keyboard navigation in grid dropdowns should not be reversed in RTL editor. Closes #12871.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Nov 29, 2022
@CKEditorBot CKEditorBot added this to the iteration 59 milestone Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@illia-stv illia-stv

Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 59 (v35.4.0)
4 participants
@mlewand @Dumluregn @CKEditorBot @illia-stv