Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltips in the link actions view won't go away when hidden using Esc key press #12492

Closed
oleq opened this issue Sep 20, 2022 · 0 comments Β· Fixed by #12572
Closed

Tooltips in the link actions view won't go away when hidden using Esc key press #12492

oleq opened this issue Sep 20, 2022 · 0 comments Β· Fixed by #12572
Assignees
Labels
intro Good first ticket. package:link package:ui squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.

Comments

@oleq
Copy link
Member

oleq commented Sep 20, 2022

πŸ“ Provide detailed reproduction steps (if any)

  1. Create a link
  2. Click it
  3. Hover an UI in the link actions view
  4. Press ESC

βœ”οΈ Expected result

The tooltip is gone.

❌ Actual result

The tooltip stays

2022-09-20 15 14 44

❓ Possible solution

It does not happen in the LinkFormView, though. This is probably because one of the handlers (blur or mouseleave) gets a chance to hide the tooltip in that case. The key to the right fix is figuring out the difference in behavior between LinkActionsView and LinkFormView.

this.listenTo( global.document, 'mouseenter', this._onEnterOrFocus.bind( this ), { useCapture: true } );
this.listenTo( global.document, 'mouseleave', this._onLeaveOrBlur.bind( this ), { useCapture: true } );
this.listenTo( global.document, 'focus', this._onEnterOrFocus.bind( this ), { useCapture: true } );
this.listenTo( global.document, 'blur', this._onLeaveOrBlur.bind( this ), { useCapture: true } );
this.listenTo( global.document, 'scroll', this._onScroll.bind( this ), { useCapture: true } );

Also note that the link UI is probably only one of many examples of this problem. We need a generic solution in TooltipManager, not a hack in ckeditor5-link.


If you'd like to see this fixed sooner, add a πŸ‘ reaction to this post.

@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. package:ui type:regression This issue reports a bug that was not present in the previous releases. package:link intro Good first ticket. labels Sep 20, 2022
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Sep 21, 2022
@mlewand mlewand changed the title [Regression] Tooltips in the link actions view won't go away when hidden using Esc key press Tooltips in the link actions view won't go away when hidden using Esc key press Sep 26, 2022
@pomek pomek added the squad:features Issue to be handled by the Features team. label Sep 28, 2022
@mateuszzagorski mateuszzagorski self-assigned this Oct 3, 2022
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Oct 3, 2022
mmotyczynska added a commit that referenced this issue Oct 14, 2022
…oltip

Fix (ui): Tooltip should hide when an element the tooltip is attached to also hides. Closes #12492.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 14, 2022
@CKEditorBot CKEditorBot added this to the iteration 58 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intro Good first ticket. package:link package:ui squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior. type:regression This issue reports a bug that was not present in the previous releases.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants