Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inserting image does not move focus out of the toolbar #12229

Closed
mateuszzagorski opened this issue Aug 5, 2022 · 2 comments · Fixed by #12238
Closed

Inserting image does not move focus out of the toolbar #12229

mateuszzagorski opened this issue Aug 5, 2022 · 2 comments · Fixed by #12238
Assignees
@mateuszzagorski
Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. package:image squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 56 (v35...

Comments

@mateuszzagorski
Copy link
Contributor

mateuszzagorski commented Aug 5, 2022 •
edited
Loading

📝 Provide detailed reproduction steps (if any)

After using the insert image, the focus stays on the toolbar button:

Nagranie.z.ekranu.2022-08-9.o.10.14.32.mov

✔️ Expected result

Focus should be moved onto the image.

❌ Actual result

Focus stays on the toolbar button.

📃 Other details

This is also happening on a non-collapsed toolbar.
All of the ui components in the ckeditor5-image should work correctly.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@mateuszzagorski mateuszzagorski added type:bug This issue reports a buggy (incorrect) behavior. domain:accessibility This issue reports an accessibility problem. squad:features Issue to be handled by the Features team. labels Aug 5, 2022
@mateuszzagorski mateuszzagorski self-assigned this Aug 5, 2022
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Aug 5, 2022
@Dumluregn
Copy link
Contributor

While working on it we should also ensure that #12178 (comment) is working as expected (it should be fixed with the same code but let's be sure).

@mateuszzagorski mateuszzagorski mentioned this issue Aug 8, 2022
Merged
@mlewand mlewand added the domain:ui/ux This issue reports a problem related to UI or UX. label Aug 9, 2022
@mlewand
Copy link
Contributor

mlewand commented Aug 9, 2022

While working on it we should also ensure that #12178 (comment) is working as expected (it should be fixed with the same code but let's be sure).

I wonder how is it possible that we never noticed it 😅 IMO it has a major impact on the UX of image feature with balloon toolbars.

mlewand added a commit that referenced this issue Aug 9, 2022
@mlewand
Merge pull request #12238 from ckeditor/ck/12229-insert-image-focus
f2ae593 
Fix (image): Fixed the focus after inserting an image - it is now moved moved to editable. Closes #12229.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Aug 9, 2022
@mlewand mlewand mentioned this issue Aug 9, 2022
Closed
@CKEditorBot CKEditorBot added this to the iteration 56 milestone Aug 9, 2022
@Dumluregn Dumluregn mentioned this issue Aug 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mateuszzagorski mateuszzagorski

Labels
domain:accessibility This issue reports an accessibility problem. domain:ui/ux This issue reports a problem related to UI or UX. package:image squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 56 (v35.1.0)
Development

Successfully merging a pull request may close this issue.

Move focus to editable after inserting image ckeditor/ckeditor5
4 participants
@mlewand @Dumluregn @mateuszzagorski @CKEditorBot