Can't close the block toolbar

[Mgsy]

📝 Provide detailed reproduction steps (if any)

1. Go to http://localhost:8081/ckeditor5/34.2.0/examples/builds/balloon-block-editor.html.
2. Focus the editor.
3. Open the block toolbar with a mouse click.
4. Close the block toolbar with a mouse click.

✔️ Expected result

The block toolbar disappears.

❌ Actual result

It's impossible to close the block toolbar.

Notes

It's possible to close the block toolbar with Esc.

---

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

[mlewand]

The difference is that during the (this side) button's execute event the toolbar is already hidden and focus is brought back to the button itself.

So this.panelView.isVisible is evaluating to false here:

ckeditor5/packages/ckeditor5-ui/src/toolbar/block/blocktoolbar.js

Line 287 in d6e41d5

if ( !this.panelView.isVisible ) {

This sounds to me like a result of focus management brought in #12162

[Dumluregn]

This sounds to me like a result of focus management brought in #12162

I'd be surprised if that's true as we only touched the dropdown behaviour. I'll check if this issue was reproducible before merging that PR.

[Dumluregn]

I checked the manual test http://localhost:8125/ckeditor5-build-balloon-block/tests/manual/ckeditor.html at the a0244b0 commit (so before all commits from #12162) and this problem is already present there.

[mlewand]

Indeed the issue came from #12003

In a52516a we removed the prevent default method call for click event. This causes the button to gain focus and panel to close prematurely.

[mlewand]

A patch that fixes (this particular issue) is in https://github.com/ckeditor/ckeditor5/tree/ck/12184-closing-balloon-block-toolbar-focus

[mateuszzagorski]

The patch in https://github.com/ckeditor/ckeditor5/tree/ck/12184-closing-balloon-block-toolbar-focus does not seem to resolve the issue on Safari.
I've prepared a solution for all of the issues on a separate branch -> ck/12184-balloon-block-toolbar-closing