Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for timestamp in embedded YouTube videos #12006

Closed
Recursing opened this issue Jul 2, 2022 · 0 comments · Fixed by #12007
Closed

Allow for timestamp in embedded YouTube videos #12006

Recursing opened this issue Jul 2, 2022 · 0 comments · Fixed by #12007
Labels
package:media-embed squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 55 (v35...

Comments

@Recursing
Copy link
Contributor

Recursing commented Jul 2, 2022 •
edited
Loading

📝 Provide a description of the improvement

It's currently possible to easily embed a YouTube video. With this change, it's possible to start the embedded video at a specific timestamp.

e.g. https://www.youtube.com/embed/WhWc3b3KhnY?start=361

📃 Other details

  • Browser: all
  • OS: all
  • CKEditor version: 5
  • Installed CKEditor plugins: MediaEmbed

I think it's a very small change (see #12007 )

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@Recursing Recursing added the type:improvement This issue reports a possible enhancement of an existing feature. label Jul 2, 2022
Recursing added a commit to Recursing/ckeditor5 that referenced this issue Jul 2, 2022
@Recursing
Feature (media-embed): Support timestamp in embedded youtube video. C…
5613791 
…loses ckeditor#12006.
@Reinmar Reinmar mentioned this issue Jul 19, 2022
Merged
@Reinmar Reinmar added package:media-embed squad:core Issue to be handled by the Core team. labels Jul 19, 2022
arkflpc added a commit that referenced this issue Jul 19, 2022
@arkflpc
Merge pull request #12007 from Recursing/i/12006
376227b 
Feature (media-embed): Support timestamp in embedded youtube video. Closes #12006.
@CKEditorBot CKEditorBot added this to the iteration 55 milestone Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:media-embed squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 55 (v35.0.0)
3 participants
@Reinmar @Recursing @CKEditorBot