Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Style dropdown] Inline styles are not disabled in the code block #11581

Closed
Tracked by #11574
niegowski opened this issue Apr 7, 2022 · 0 comments · Fixed by #11703
Closed
Tracked by #11574

[Style dropdown] Inline styles are not disabled in the code block #11581

niegowski opened this issue Apr 7, 2022 · 0 comments · Fixed by #11703
Labels
package:style squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 53 (v34...

Comments

@niegowski
Copy link
Contributor

📝 Provide detailed reproduction steps (if any)

  1. Select some text inside a code block or place a caret inside a code block
  2. Open styles dropdown
  3. Apply any inline style

✔️ Expected result

Inline styles should be disabled there.

❌ Actual result

Inline styles are enabled but not applied.
2022-04-07 10 45 39

❓ Possible solution

Code block disables attributes on text inside it but the styles dropdown does not reflect it.

📃 Other details

  • Browser: …
  • OS: …
  • First affected CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@niegowski niegowski added type:bug This issue reports a buggy (incorrect) behavior. squad:core Issue to be handled by the Core team. package:style labels Apr 7, 2022
@niegowski niegowski mentioned this issue May 4, 2022
Merged
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. labels May 4, 2022
oleq added a commit that referenced this issue May 5, 2022
@oleq
Merge pull request #11703 from ckeditor/ck/11574-refactor
5026d51 
Internal (style): The `StyleCommand` got refactored. Closes #11607.

Fix (style): The block style should be applied to all matching selected blocks. Closes #11582.

Fix (style): Inline style can be removed from an inline widget. Closes #11584.

Fix (style): Inline styles should not be enabled inside a code block. Closes #11581

Fix (style): Container styles (for example a block quote style) should be applied properly. Closes #11576.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label May 5, 2022
@CKEditorBot CKEditorBot added this to the iteration 53 milestone May 5, 2022
@Reinmar Reinmar mentioned this issue Nov 10, 2022
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:style squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 53 (v34.1.0)
Development

Successfully merging a pull request may close this issue.

Refactored StyleCommand ckeditor/ckeditor5
2 participants
@niegowski @CKEditorBot