Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update read-only docs after recent changes #11572

Closed
FilipTokarski opened this issue Apr 6, 2022 · 3 comments
Closed

Update read-only docs after recent changes #11572

FilipTokarski opened this issue Apr 6, 2022 · 3 comments
Assignees
@ma2ciek
Labels
release:potential-blocker This issue potentially blocks the upcoming release (should be checked). squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Milestone
iteration 53 (v34...

Comments

@FilipTokarski
Copy link
Member

FilipTokarski commented Apr 6, 2022 •
edited
Loading

📝 Provide a description of requested docs changes

Recent changes should be reflected in the main read-only docs. Currently they are only in the migration guide.
Feature description should be adjusted to the new way os setting read-only mode. I think we also should add a short snippet like in the migration guide.
@FilipTokarski FilipTokarski added type:bug This issue reports a buggy (incorrect) behavior. type:docs This issue reports a task related to documentation (e.g. an idea for a guide). release:potential-blocker This issue potentially blocks the upcoming release (should be checked). labels Apr 6, 2022
@ma2ciek ma2ciek self-assigned this Apr 6, 2022
@ma2ciek ma2ciek added the squad:collaboration Issue to be handled by the Collaboration team. label Apr 6, 2022
@ma2ciek
Copy link
Contributor

ma2ciek commented Apr 7, 2022 •
edited
Loading

But to be honest I'd expect this guide to be in Framework/User interface, not in Features. WDYT about this change?

@FilipTokarski
Copy link
Member Author

Let's leave it where it is for now, we'll discuss this on CCX sync.

@ma2ciek ma2ciek mentioned this issue Apr 11, 2022
Merged
scofalik added a commit that referenced this issue Apr 11, 2022
@scofalik
Merge pull request #11611 from ckeditor/ck/11572
7d018df 
Internal: Fix docs for the editor's read-only mode management. Closes #11572.
@scofalik
Copy link
Contributor

Merged to release.

@scofalik scofalik added this to the iteration 53 milestone Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ma2ciek ma2ciek

Labels
release:potential-blocker This issue potentially blocks the upcoming release (should be checked). squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior. type:docs This issue reports a task related to documentation (e.g. an idea for a guide).
Projects
None yet
Milestone
iteration 53 (v34.1.0)
Development

No branches or pull requests
3 participants
@scofalik @ma2ciek @FilipTokarski