Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GHS] document form MS Word causes error being thrown #11477

Closed
jswiderski opened this issue Mar 17, 2022 · 1 comment · Fixed by #11488
Closed

[GHS] document form MS Word causes error being thrown #11477

jswiderski opened this issue Mar 17, 2022 · 1 comment · Fixed by #11488
Assignees
@arkflpc
Labels
package:html-support package:paste-from-office squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 52 (v34...

Comments

@jswiderski
Copy link

📝 Provide detailed reproduction steps (if any)

  1. Open attached sample MS Word file.
  2. Paste its contents into demo with GHS fully enabled - https://ckeditor.com/docs/ckeditor5/latest/features/general-html-support.html#demo

sample 2.zip

✔️ Expected result

Dosument gets pasted

❌ Actual result

JS error gets thrown -> CKEditorError: target[key] is undefined

❓ Possible solution

If you have ideas, you can list them here. Otherwise, you can delete this section.

📃 Other details

  • Browser: Any
  • OS: Any
  • First affected CKEditor version:
  • Installed CKEditor plugins: paste-from-office

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@jswiderski jswiderski added type:bug This issue reports a buggy (incorrect) behavior. package:paste-from-office labels Mar 17, 2022
@Reinmar Reinmar mentioned this issue Mar 17, 2022
Closed
@Reinmar
Copy link
Member

Reinmar commented Mar 17, 2022

We'll be working soon on a bug that throws the same error (#11450) so hopefully this issue will be resolved too.

@Reinmar Reinmar added squad:core Issue to be handled by the Core team. package:html-support labels Mar 17, 2022
@martynawierzbicka martynawierzbicka added the support:2 An issue reported by a commercially licensed client. label Mar 17, 2022
@arkflpc arkflpc self-assigned this Mar 18, 2022
@arkflpc arkflpc mentioned this issue Mar 18, 2022
Merged
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Mar 18, 2022
dawidurbanski added a commit that referenced this issue Mar 21, 2022
@dawidurbanski
Merge pull request #11488 from ckeditor/ck/fix-ghs-mergeViewElementAt…
bc6e4d4 
…tributes

Fix (html-support): Prevent `TypeError` in `mergeViewElementAttributes`. Closes #10657. Closes #11450. Closes #11477.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Mar 21, 2022
@CKEditorBot CKEditorBot added this to the iteration 52 milestone Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkflpc arkflpc

Labels
package:html-support package:paste-from-office squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 52 (v34.0.0)
Development

Successfully merging a pull request may close this issue.

GHS: fix mergeViewElementAttributes ckeditor/ckeditor5
5 participants
@Reinmar @jswiderski @arkflpc @CKEditorBot @martynawierzbicka