Auto-link correction

[net3000]

📝 Provide detailed reproduction steps (if any)

1. …type www.google.com in content (without http)
2. …inspect the link, you'll find it with href='www.google.com' which is invalid

✔️ Expected result

href='https://www.google.com'

❌ Actual result

href='www.google.com'

❓ Possible solution

Either auto-link would add https:// to the link, or doesn't link www.google.com

[Reinmar]

I can confirm this issue. Thank you for reporting it.

[Reinmar]

The question we could ask is whether we can assume that a website supports https? Maybe we shouldn't create the link at all in this case.

I'd agree, though, that going with https makes more sense as if someone typed a link, then it's most likely to a well-known website that most likely support https already. Also, this is more future-oriented.

[net3000]

It’s safer not to make the link since the user didn’t type a valid link. The second option to automatically add: https means it can still potentially load an invalid URL and user will blame it on editor. Wael Hallag Phone: +1-416-875-4044 (WhatsApp, Viber, IMO, Line) Skype: Net3000.ca Facebook Messenger: ***@***.***> ***@***.*** From: Piotrek Koszuliński ***@***.***> Sent: Thursday, December 23, 2021 4:52 AM To: ckeditor/ckeditor5 ***@***.***> Cc: Wael Hallag ***@***.***>; Author ***@***.***> Subject: Re: [ckeditor/ckeditor5] Auto-link correction (Issue #11040) The question we could ask is whether we can assume that a website supports https? Maybe we shouldn't create the link at all in this case. I'd agree, though, that going with https makes more sense as if someone typed a link, then it's most likely to a well-known website that most likely support https already. Also, this is more future-oriented. — Reply to this email directly, view it on GitHub <#11040 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACYGNHKIXOXMG5PVRLC353LUSLWLRANCNFSM5KSPSWCQ> . You are receiving this because you authored the thread. <https://github.com/notifications/beacon/ACYGNHOWDTCGVHQAJ3ONPFLUSLWLRA5CNFSM5KSPSWC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHOOYFHA.gif> Message ID: ***@***.*** ***@***.***> >

[neongreen]

I think I've seen this being solved with a "defaultProtocol" config option in some other library (can choose http if you want to err on the side of caution or https if you don't care). Don't remember what it was though. Maybe a Markdown library or another editor widget.

I personally would be much happier with https:// than with autolink being disabled for google.com.

[pomek]

Couldn't we re-use already implemented the config.link.defaultProtocol option?

[scofalik]

config.link.defaultProtocol is actually used (if set) when autolinking.

[scofalik]

We decided to cancel auto-linking if: there's no default protocol and the URL does not contain protocol:

1. www.ckeditor.com will not get autolinked if default protocol is not set.
2. www.ckeditor.com will get autolinked using default protocol, if default protocol is set.
3. ckeditor.com will never get autolinked.
4. http://ckeditor.com and http://www.ckeditor.com will get autolinked with http:// no matter what default protocol is used.