Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown split button divider does not stretch 100% height of the button #10936

Closed
oleq opened this issue Dec 2, 2021 · 0 comments · Fixed by #12815
Closed

Dropdown split button divider does not stretch 100% height of the button #10936

oleq opened this issue Dec 2, 2021 · 0 comments · Fixed by #12815
Assignees
@illia-stv
Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:theme-lark squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 59 (v35...

Comments

@oleq
Copy link
Member

oleq commented Dec 2, 2021

📝 Provide detailed reproduction steps (if any)

At first, I thought this is caused by the unnecessary border radius applied to the right side corners of the main button/left side corners of the secondary button but after zooming in I found out it's the divider not stretching properly.

📃 Other details

  • Browser: Cross-browser
  • OS: Cross-OS
  • First affected CKEditor version: ?

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. intro Good first ticket. package:theme-lark domain:ui/ux This issue reports a problem related to UI or UX. labels Dec 2, 2021
@mlewand mlewand added the squad:features Issue to be handled by the Features team. label Nov 7, 2022
@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Nov 7, 2022
@Dumluregn Dumluregn mentioned this issue Nov 8, 2022
Merged
oleq added a commit that referenced this issue Nov 14, 2022
@oleq
Merge pull request #12815 from ckeditor/ck/10936-dropdown-split-butto…
8f00d4a 
…n-divider-does-not-stretch-100%-height-of-the-button

Fix (ui): The split button divider should stretch to the edges of the button. Closes #10936.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Nov 14, 2022
@CKEditorBot CKEditorBot added this to the iteration 59 milestone Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@illia-stv illia-stv

Labels
domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:theme-lark squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 59 (v35.4.0)
Development

Successfully merging a pull request may close this issue.

Dropdown split button divider does not stretch 100% height of the button ckeditor/ckeditor5
4 participants
@oleq @mlewand @CKEditorBot @illia-stv