Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is possible to replace using Enter key despite the replace input and buttons disabled #10712

Closed
oleq opened this issue Oct 18, 2021 · 0 comments · Fixed by #10873
Closed

It is possible to replace using Enter key despite the replace input and buttons disabled #10712

oleq opened this issue Oct 18, 2021 · 0 comments · Fixed by #10873
Assignees
@CatStrategist
Labels
intro Good first ticket. package:find-and-replace squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 49 (v31...

Comments

@oleq
Copy link
Member

oleq commented Oct 18, 2021 •
edited
Loading

📝 Provide detailed reproduction steps (if any)

  1. Find something
  2. Type text in a replace field
  3. Type something else in the find field (but don't hit "Find")
  4. Focus the replace field
  5. Hit enter

✔️ Expected result

Nothing should happen. The replace input is disabled because criteria have changed. Replace buttons are disabled.

❌ Actual result

Text gets replaced.

❓ Possible solution

I noticed that replace/replaceall commands are always enabled and the UI is bound to the find's state. ATM the replacement is possible as long as there was anything typed in the find input. It should not be possible when the form is dirty (there's a flag for that).

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. squad:core Issue to be handled by the Core team. package:find-and-replace intro Good first ticket. labels Oct 18, 2021
@CatStrategist CatStrategist self-assigned this Nov 16, 2021
CatStrategist pushed a commit that referenced this issue Nov 20, 2021
#10712 Skip executing replace command when search input is dirty
cdcb4bc
@CatStrategist CatStrategist mentioned this issue Nov 20, 2021
Merged
niegowski added a commit that referenced this issue Nov 23, 2021
@niegowski
Merge pull request #10873 from ckeditor/ck/10712-disable-replace-when…
4bc9646 
…-find-input-is-dirty

Fix (find-and-replace): Replace functionality no longer replaces text when 'Replace with...' input is focused and user hits `enter` key but search criteria changed. Closes #10712.
@Reinmar Reinmar added this to the iteration 49 milestone Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CatStrategist CatStrategist

Labels
intro Good first ticket. package:find-and-replace squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 49 (v31.1.0)
Development

Successfully merging a pull request may close this issue.

#10712 Skip executing replace command when search input is dirty ckeditor/ckeditor5
3 participants
@Reinmar @oleq @CatStrategist