Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make properties of HtmlDataProcessor and XmlDataProcessor public. #10619

Closed
arkflpc opened this issue Sep 29, 2021 · 0 comments · Fixed by #10620
Closed

Make properties of HtmlDataProcessor and XmlDataProcessor public. #10619

arkflpc opened this issue Sep 29, 2021 · 0 comments · Fixed by #10620
Assignees
@arkflpc
Labels
squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 48 (v31...

Comments

@arkflpc
Copy link
Contributor

arkflpc commented Sep 29, 2021

📝 Provide a description of the improvement

Expose properties of HtmlDataProcessor and XmlDataProcessor to allow influencing their behavior (i.e. by changing xmlWriter to a custom one).

📃 Other details

Properties to expose:

  • domConverter
  • domParser 
  • htmlWriter

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@arkflpc arkflpc added type:task This issue reports a chore (non-production change) and other types of "todos". squad:core Issue to be handled by the Core team. labels Sep 29, 2021
@arkflpc arkflpc mentioned this issue Sep 29, 2021
Merged
Reinmar added a commit that referenced this issue Sep 30, 2021
@Reinmar
Merge pull request #10620 from ckeditor/ck/10619-dataprocessor-public…
b097349 
…-properties

Other (engine): Made properties of `XmlDataProcessor` and `HtmlDataProcessor` public to allow overriding e.g. the HTML writer. Closes #10619.
@Reinmar Reinmar added this to the iteration 48 milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkflpc arkflpc

Labels
squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 48 (v31.0.0)
Development

Successfully merging a pull request may close this issue.

Ck/10619 dataprocessor public properties ckeditor/ckeditor5
2 participants
@Reinmar @arkflpc