Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong styling in decoupled document build sample file #10095

Closed
FilipTokarski opened this issue Jul 7, 2021 · 0 comments · Fixed by #10176
Closed

Wrong styling in decoupled document build sample file #10095

FilipTokarski opened this issue Jul 7, 2021 · 0 comments · Fixed by #10176
Assignees
@FilipTokarski
Labels
package:build-decoupled-document squad:ccx Issue to be handled by the CCX team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 45 (v29...

Comments

@FilipTokarski
Copy link
Member

📝 Provide detailed reproduction steps (if any)

  1. Open packages/ckeditor5-build-decoupled-document/sample/index.html

✔️ Expected result

0_editable_ok

❌ Actual result

0_editable_bad

❓ Possible solution

Selector should be changed from:

.editable-container .document-editor__editable.ck-editor__editable

to:

.editable-container .ck-editor__editable

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@FilipTokarski FilipTokarski added type:bug This issue reports a buggy (incorrect) behavior. package:build-decoupled-document squad:ccx Issue to be handled by the CCX team. labels Jul 7, 2021
@FilipTokarski FilipTokarski self-assigned this Jul 7, 2021
@FilipTokarski FilipTokarski mentioned this issue Jul 19, 2021
Merged
@FilipTokarski FilipTokarski added this to the iteration 45 milestone Jul 19, 2021
oleq added a commit that referenced this issue Jul 20, 2021
@oleq
Merge pull request #10176 from ckeditor/ck/10095
3d35544 
Fix (build-decoupled-document): The editing area in the sample should have a solid white background. Closes #10095.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FilipTokarski FilipTokarski

Labels
package:build-decoupled-document squad:ccx Issue to be handled by the CCX team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 45 (v29.1.0)
Development

Successfully merging a pull request may close this issue.

Fixed style of decoupled document build sample ckeditor/ckeditor5
1 participant
@FilipTokarski