Skip to content

Commit

Permalink
(Hack) Excluded the TooltipManager singleton from the ContextWatchdog…
Browse files Browse the repository at this point in the history
… property connection.
  • Loading branch information
oleq committed Aug 18, 2022
1 parent 053764b commit 6ea5bf4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions packages/ckeditor5-ui/src/tooltipmanager.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ export default class TooltipManager {
* @param {module:core/editor/editor~Editor} editor
*/
constructor( editor ) {
// See: ContextWatchdog.
this._watchdogExcluded = true;

TooltipManager._editors.add( editor );

// TooltipManager must be a singleton. Multiple instances would mean multiple tooltips attached
Expand Down
1 change: 1 addition & 0 deletions packages/ckeditor5-watchdog/src/utils/getsubnodes.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ function shouldNodeBeSkipped( node ) {

node === undefined ||
node === null ||
node._watchdogExcluded === true ||

// Skip native DOM objects, e.g. Window, nodes, events, etc.
node instanceof EventTarget ||
Expand Down

0 comments on commit 6ea5bf4

Please sign in to comment.