This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Remove the CKEditor 5 logger and its usage #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjasiun
reviewed
Jul 12, 2019
src/dom/rect.js
Outdated
| 'rect-source-not-in-dom: The source of this rect does not belong to any rendered DOM tree.', | ||
| { source } | ||
| ); | ||
| ), { source } ); |
There was a problem hiding this comment.
This should be displayed only in the debug mode, this error tells nothing to end users.
There was a problem hiding this comment.
Maybe the error code/message could be better? Because I think that the warning should be displayed at least.
pjasiun
reviewed
Jul 12, 2019
src/version.js
Outdated
| @@ -138,7 +138,9 @@ if ( windowOrGlobal.CKEDITOR_VERSION ) { | |||
| * | |||
| * @error ckeditor-duplicated-modules | |||
| */ | |||
| log.error( 'ckeditor-duplicated-modules: Some CKEditor 5 modules are duplicated.' ); | |||
| console.error( attachLinkToDocumentation( | |||
There was a problem hiding this comment.
This should be CKEditorError expectation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Removed the CKEditor 5 logger and its usage. Part of ckeditor/ckeditor5#383.
Additional information
Requires other connected PRs to be merged first.
For example – encountered issues, assumptions you had to make, other affected tickets, etc.