This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Introduced the
SelectView
component. Closes ckeditor/ckeditor5#5770.Additional information
I didn't implement
isReadOnly
property asreadonly
is not supported onselect
elements in HTML so that would require workarounds.Also I was wondering whether changing value to a value that is not contained by the select should throw an error or silently fail, doing no harm. I went with the latter, though it would be nice to log some information, but I believe we have no common mechanisms for that.
There's a subpr with manual test to this component: ckeditor/ckeditor5-theme-lark#253