This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Added beforeShow event to the ContextualToolbar plugin #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleq
suggested changes
May 10, 2017
There was a problem hiding this comment.
Got some questions. The code is nasty but it will be fixed in https://github.com/ckeditor/ckeditor5-ui/issues/225.
| }, { priority: 'lowest' } ); | ||
|
|
||
| // Fire this event to inform interested plugins that `ContextualToolbar` is going to be shown. | ||
| this.fire( 'beforeShow' ); |
There was a problem hiding this comment.
Can't we pass the stopping function along this event to avoid the additional stop method?
| balloonClassName: 'ck-toolbar-container' | ||
| } ); | ||
| // If `beforeShow` event is not stopped by any external code then panel will be displayed. | ||
| this.listenTo( this, 'beforeShow', ( evt ) => { |
There was a problem hiding this comment.
Wouldn't once() mean that evt.off() at the end is gone?
There was a problem hiding this comment.
once() uses on() but on() is not cleared on stopListening() (https://github.com/ckeditor/ckeditor5-utils/issues/144). That's why I used evt.off().
oleq
reviewed
May 10, 2017
| // If `beforeShow` event is not stopped by any external code then panel will be displayed. | ||
| this.once( 'beforeShow', () => { | ||
| if ( isStopped ) { | ||
| isStopped = false; |
There was a problem hiding this comment.
Why do we need to reset the value of it?
There was a problem hiding this comment.
We don't. Fixing...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Added
beforeShowevent to theContextualToolbarplugin. Closes ckeditor/ckeditor5#5353.