This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
t/119: New tooltip architecture #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boolean, String or Function data type. Bound tooltip–specific ButtonView class to the presence of Enabled new ButtonView tooltip API in createDropdown helper.
|
Is it correct that tooltip isn't displayed for disabled buttons? |
|
Yes. It's by design. In fact, I was wondering if this is correct but decided that less distraction is better. The button isn't available anyway. OTOH, I'm aware that this is a blow to the feature discoverability. |
Reinmar
added a commit
to ckeditor/ckeditor5-basic-styles
that referenced
this pull request
Jan 3, 2017
Reinmar
added a commit
to ckeditor/ckeditor5-link
that referenced
this pull request
Jan 3, 2017
|
I think it's a bit strange when e.g. you have a disabled undo or redo buttons (redo is disabled most of the time, while undo isn't). |
Reinmar
added a commit
to ckeditor/ckeditor5-list
that referenced
this pull request
Jan 3, 2017
Reinmar
added a commit
to ckeditor/ckeditor5-undo
that referenced
this pull request
Jan 3, 2017
|
Let's find out what people will say. It's a single line of CSS to re–enable them. |
|
Please re-enable them. This is the default behavior with "title" and users must have a clue on what is that disabled button about. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/ckeditor/ckeditor5-ui/issues/119.
Closes ckeditor/ckeditor5-ui-default#147.
Closes ckeditor/ckeditor5-ui-default#148.