This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
T/82 Spanish accent character is removed while typed in non-collapsed selection. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinmar
reviewed
Mar 10, 2017
tests/manual/82/1.js
Outdated
| plugins: [ Enter, Typing, Paragraph, Undo, Heading ], | ||
| toolbar: [ 'headings', 'undo', 'redo' ] | ||
| } ) | ||
| .then( editor => { |
There was a problem hiding this comment.
Please don't indent these. I know that in some tests they are indented, but I'm trying to fix all of them :D
There was a problem hiding this comment.
Sorry, forgot again about this one. Fixed. I will try to remember next time :)
Reinmar
reviewed
Mar 10, 2017
| /* globals console, window, document */ | ||
|
|
||
| import ClassicEditor from '@ckeditor/ckeditor5-editor-classic/src/classic'; | ||
| import Enter from '@ckeditor/ckeditor5-enter/src/enter'; |
There was a problem hiding this comment.
For the future – you can use presets/essentials to provide these basic plugins.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Spanish accent character properly inserted on non-collapsed selection. Closes ckeditor/ckeditor5#3078.