This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
DeleteObserver cancells keydown event when delete event is cancelled. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mgsy
approved these changes
Jan 5, 2018
|
I'm missing an integration test. How do you know that the issue was fixed? |
|
I'll add this test. And it needs to go to ckeditor5-widget so we can close this PR anyway. |
|
Changes Unknown when pulling 4874278 on t/ckeditor5/753 into ** on master**. |
|
I improved existing tests to they catch this situation: ckeditor/ckeditor5-widget@12c51b2. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix:
DeleteObserverstopskeydownevent whendeleteevent is stopped. Closes: ckeditor/ckeditor5#753.Please close together with: ckeditor/ckeditor5-enter#51.