Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Safari] Spanish accent character is removed while typed in non-collapsed selection. #3078

Closed
f1ames opened this issue Mar 9, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-typing#84
Closed

[Safari] Spanish accent character is removed while typed in non-collapsed selection. #3078

f1ames opened this issue Mar 9, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-typing#84
Assignees
@f1ames
Labels
package:typing type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 9

Comments

@f1ames
Copy link
Contributor

f1ames commented Mar 9, 2017

  1. Go to http://localhost:8125/ckeditor5-typing/tests/manual/input.html.
  2. Create non-collapsed selection on content like <p>Foo [bar]</p>.
  3. Use Spanish-ISO keyboard and press ' (accent).

Accent is removed just after it was inserted. This is caused by the unsafe key hack.
@f1ames f1ames self-assigned this Mar 10, 2017
f1ames referenced this issue in ckeditor/ckeditor5-typing Mar 10, 2017
@f1ames
Tests: #82 manual and unit test.
817d3c1
Reinmar referenced this issue in ckeditor/ckeditor5-typing Mar 10, 2017
@Reinmar
Merge pull request #84 from ckeditor/t/82
49cfe9c 
Fix: [Safari] Fixed an issue when inserting a Spanish accent character on a non-collapsed selection wouldn't work. Closes #82.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-typing Oct 9, 2019
@mlewand mlewand added this to the iteration 9 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:typing labels Oct 9, 2019
@f1ames f1ames mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@f1ames f1ames

Labels
package:typing type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 9
2 participants
@f1ames @mlewand