This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
i/6446: Fix the table selection background #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e future reference.
|
Agree. It looks awesome. The glitch on FF is fine. I'd only consider slightly more opaque overlay to make it a bit more visible. |
It could be then too contrasty with a white cell background and distort the text color too much at the same time. ATM it looks fine I think I played a little with the opacity of the overlay color (up to .6) and the Before:
After:
WDYT? |
|
For me, selected items should be brighter (washed out). The same situation we have, ie: in Google Docs:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Improved table cell background in multi selection. Closes ckeditor/ckeditor5#6446.
Additional information