Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

T/4: Initial table support #6

Closed
wants to merge 61 commits into from
Closed

T/4: Initial table support #6

wants to merge 61 commits into from

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Apr 9, 2018

Suggested merge commit message (convention)

Feature: Initial table support. Closes ckeditor/ckeditor5#3162.


Additional information

In this PR I've created the fundamentals for table editing:

  • upcast conversion
  • downcast conversion which supports table editing:
    • inserting table
    • inserting a table row with children
    • inserting a table cell
    • changing table attributes (number of heading rows & columns)

The downcast conversion was tested for upcoming commands that could:

  • split table cell
  • merge two cells

All above works with colspan & rowspan attributes support.

The commands for those operation were not implemented as it would require additional time to develop them.

Also this PR contains the preliminary implementation of some commands:

  • insert table (with basic button UI) - support rows & columns values (UI button always insert 2x2 table)
  • insert row (with basic button UI) - command supports insert position & number of row (UI button always insert at the beginningt)
  • insert column (with basic button UI) - command supports insert position & number of columns (UI button always insert at the beginning)
    but their code might not be ideal due to focus on conversion itself.

As in ckeditor/ckeditor5#3162 I do not implement or care about:

  • cursor movement
  • selection
  • pasting
  • UI
  • no widget
  • no <p> handling inside table cells
  • no caption and no tfoot in view output

@zeopix
Copy link

zeopix commented Apr 10, 2018

👍

@jodator
Copy link
Contributor Author

jodator commented Apr 27, 2018

Due to @Reinmar being busy releasing CKEditor 5 v10.0.0 (I love those numbers btw) we've decided to close this PR in favor of one big PR which will cover this (#4) and also table widget (#7) and table commands (#9). The current state of work is on branch t/9 and this will be merged after some commands polishing.

@jodator jodator closed this Apr 27, 2018
@jodator jodator mentioned this pull request May 10, 2018
@jodator jodator deleted the t/4 branch May 10, 2018 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimal table support
2 participants