This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
T/4: Initial table support #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lspan attributes.
👍 |
Due to @Reinmar being busy releasing CKEditor 5 v10.0.0 (I love those numbers btw) we've decided to close this PR in favor of one big PR which will cover this (#4) and also table widget (#7) and table commands (#9). The current state of work is on branch |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Initial table support. Closes ckeditor/ckeditor5#3162.
Additional information
In this PR I've created the fundamentals for table editing:
The downcast conversion was tested for upcoming commands that could:
All above works with
colspan
&rowspan
attributes support.The commands for those operation were not implemented as it would require additional time to develop them.
Also this PR contains the preliminary implementation of some commands:
but their code might not be ideal due to focus on conversion itself.
As in ckeditor/ckeditor5#3162 I do not implement or care about:
<p>
handling inside table cellscaption
and notfoot
in view output