Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Alternate icon set for table feature #20

Closed
wants to merge 12 commits into from
Closed

Alternate icon set for table feature #20

wants to merge 12 commits into from

Conversation

dtwist
Copy link
Contributor

@dtwist dtwist commented May 26, 2018

Includes:

@jodator
Copy link
Contributor

jodator commented May 28, 2018

@dtwist I didn't notice that you push that PR to t/1 sorry for braking it.

I'll update your PR after we close the #10.

@dtwist
Copy link
Contributor Author

dtwist commented May 29, 2018

No worries; let me know if it's easier to just create a new PR.

BTW, I've not received an email to sign a CLA.

@Reinmar
Copy link
Member

Reinmar commented May 29, 2018

cc @vokiel

@vokiel
Copy link

vokiel commented May 29, 2018

@dtwist your email is hidden on GH thus we couldn't deliver CLA request. Please leave as a note on https://ckeditor.com/contact/ so we'll have your real email address to send CLA request to.

@jodator
Copy link
Contributor

jodator commented May 29, 2018

@dtwist it would be nice of you actually to create a new PR 😃

The t/1 is not going to be rebased as t/9 just got merged into master and I plan to put t/1 on review tomorrow.

@dtwist
Copy link
Contributor Author

dtwist commented May 29, 2018

@vokiel email sent.

@jodator NP; what branch should I open the PR on? I'm assuming I should still create my own t/1 branch per the contribution guide?

@jodator
Copy link
Contributor

jodator commented May 30, 2018

@dtwist Yeah I think that would be OK the same way as now.

@dtwist
Copy link
Contributor Author

dtwist commented May 30, 2018

Closing, will open new PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants