Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Commit

Permalink
Other: Remove env.isEdge. Closes ckeditor/ckeditor5#6202.
Browse files Browse the repository at this point in the history
Remove some special cases for Edge, as since it's Chromium-based now, it behaves closer to others.
  • Loading branch information
tomalec committed Apr 17, 2020
1 parent 7213f93 commit 5cf3199
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
4 changes: 0 additions & 4 deletions tests/converters/downcast.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { getData as getViewData } from '@ckeditor/ckeditor5-engine/src/dev-utils
import { setData as setModelData } from '@ckeditor/ckeditor5-engine/src/dev-utils/model';

import { defaultConversion, defaultSchema, modelTable, viewTable } from '../_utils/utils';
import env from '@ckeditor/ckeditor5-utils/src/env';
import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
import { assertEqualMarkup } from '@ckeditor/ckeditor5-utils/tests/_utils/utils';

Expand Down Expand Up @@ -43,9 +42,6 @@ describe( 'downcast converters', () => {
testUtils.createSinonSandbox();

beforeEach( () => {
// Most tests assume non-edge environment but we do not set `contenteditable=false` on Edge so stub `env.isEdge`.
testUtils.sinon.stub( env, 'isEdge' ).get( () => false );

return VirtualTestEditor.create()
.then( newEditor => {
editor = newEditor;
Expand Down
4 changes: 0 additions & 4 deletions tests/converters/table-cell-refresh-post-fixer.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { getData as getViewData } from '@ckeditor/ckeditor5-engine/src/dev-utils
import { defaultConversion, defaultSchema, viewTable } from '../_utils/utils';
import injectTableCellRefreshPostFixer from '../../src/converters/table-cell-refresh-post-fixer';

import env from '@ckeditor/ckeditor5-utils/src/env';
import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
import ClassicTestEditor from '@ckeditor/ckeditor5-core/tests/_utils/classictesteditor';

Expand All @@ -26,9 +25,6 @@ describe( 'Table cell refresh post-fixer', () => {
element = document.createElement( 'div' );
document.body.appendChild( element );

// Most tests assume non-edge environment but we do not set `contenteditable=false` on Edge so stub `env.isEdge`.
testUtils.sinon.stub( env, 'isEdge' ).get( () => false );

return ClassicTestEditor.create( element, { extraPlugins: [ Delete ] } )
.then( newEditor => {
editor = newEditor;
Expand Down

0 comments on commit 5cf3199

Please sign in to comment.