Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ckeditor5-premium-features from peerDependencies #533

Merged

Conversation

filipsobol
Copy link
Member

@filipsobol filipsobol commented Sep 24, 2024

Suggested merge commit message (convention)

Fix: Improve ESM support by adding missing file extensions in imports.

Other: Remove ckeditor5-premium-features from peerDependencies.

Internal: Remove ckeditor5-premium-features from devDependencies.

Mati365
Mati365 previously approved these changes Sep 24, 2024
@Mati365 Mati365 self-requested a review September 24, 2024 13:28
@filipsobol filipsobol changed the title Remove ckeditor5 premium features from peer dependencies Remove ckeditor5-premium-features from peerDependencies Sep 25, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3d164570-11b2-435c-9863-c58cc4cb8283

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 358d9d5a-7ae0-47fd-bec0-4fc4b4e10d2e: 0.0%
Covered Lines: 582
Relevant Lines: 582

💛 - Coveralls

@filipsobol filipsobol merged commit 9b9ebe2 into master Sep 26, 2024
5 checks passed
@filipsobol filipsobol deleted the remove-ckeditor5-premium-features-from-peer-dependencies branch September 26, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants